Skip to content

Fix the bug that match does not exhaustive #5370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 25, 2023
Merged

Fix the bug that match does not exhaustive #5370

merged 1 commit into from
Jan 25, 2023

Conversation

style95
Copy link
Member

@style95 style95 commented Jan 25, 2023

Description

I am unsure how it passed the CI tests in the first place but this bug is introduced by #5229

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@codecov-commenter
Copy link

Codecov Report

Merging #5370 (e784259) into master (4bc4c3b) will decrease coverage by 11.27%.
The diff coverage is 84.64%.

❗ Current head e784259 differs from pull request most recent head 79206d2. Consider uploading reports for the commit 79206d2 to get more accurate results

@@             Coverage Diff             @@
##           master    #5370       +/-   ##
===========================================
- Coverage   76.44%   65.18%   -11.27%     
===========================================
  Files         240      233        -7     
  Lines       14407    14305      -102     
  Branches      601      638       +37     
===========================================
- Hits        11014     9325     -1689     
- Misses       3393     4980     +1587
Impacted Files Coverage Δ
.../org/apache/openwhisk/core/connector/Message.scala 58.48% <0.00%> (-11.34%) ⬇️
...e/openwhisk/core/scheduler/queue/MemoryQueue.scala 0.00% <0.00%> (-82.13%) ⬇️
...whisk/core/containerpool/AkkaContainerClient.scala 67.30% <20.00%> (-3.85%) ⬇️
...sk/core/containerpool/docker/DockerContainer.scala 90.36% <50.00%> (-5.25%) ⬇️
...pache/openwhisk/core/invoker/InvokerReactive.scala 53.07% <50.00%> (-18.80%) ⬇️
.../containerpool/ApacheBlockingContainerClient.scala 70.68% <57.14%> (-0.98%) ⬇️
...ntainerpool/v2/FunctionPullingContainerProxy.scala 78.31% <62.50%> (-0.19%) ⬇️
.../apache/openwhisk/core/controller/WebActions.scala 89.75% <75.00%> (-1.20%) ⬇️
...la/org/apache/openwhisk/core/entity/Identity.scala 82.66% <76.08%> (-10.67%) ⬇️
...nwhisk/core/invoker/ContainerMessageConsumer.scala 75.47% <87.09%> (-1.13%) ⬇️
... and 80 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dgrove-oss dgrove-oss merged commit 104c1e8 into apache:master Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrove-oss dgrove-oss dgrove-oss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@style95 @codecov-commenter @dgrove-oss